Make Loggers private, static, and final (#45)

Fix the last two straggers and make their Logger private, static, final, and named LOG for consistency
kiwiproject · Nov 7, 2023 · 38a217d · 38a217d
1 parent 7ebfee9
commit 38a217d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/...zard-jaxws/src/main/java/com/roskart/dropwizard/jaxws/BasicAuthenticationInterceptor.java b/...zard-jaxws/src/main/java/com/roskart/dropwizard/jaxws/BasicAuthenticationInterceptor.java
@@ -34,8 +34,10 @@
  */
 public class BasicAuthenticationInterceptor extends AbstractPhaseInterceptor<Message> {
 
-    private static final Logger log = LoggerFactory.getLogger(BasicAuthenticationInterceptor.class);
+    private static final Logger LOG = LoggerFactory.getLogger(BasicAuthenticationInterceptor.class);
+
     public static final String PRINCIPAL_KEY = "dropwizard.jaxws.principal";
+
     private BasicAuthentication authentication;
 
     public BasicAuthenticationInterceptor() {
@@ -101,7 +103,7 @@ private void sendErrorResponse(Message message, int responseCode) {
             getConduit(message).prepare(outMessage);
             close(outMessage);
         } catch (IOException e) {
-            log.warn(e.getMessage(), e);
+            LOG.warn(e.getMessage(), e);
         }
     }
 

diff --git a/dropwizard-jaxws/src/main/java/com/roskart/dropwizard/jaxws/JAXWSEnvironment.java b/dropwizard-jaxws/src/main/java/com/roskart/dropwizard/jaxws/JAXWSEnvironment.java
@@ -28,7 +28,7 @@
  */
 public class JAXWSEnvironment {
 
-    private static Logger log = LoggerFactory.getLogger(JAXWSEnvironment.class);
+    private static final Logger LOG = LoggerFactory.getLogger(JAXWSEnvironment.class);
 
     protected final Bus bus;
     protected final String defaultPath;
@@ -92,9 +92,9 @@ public void logEndpoints() {
                         .append(s.getEndpoint().getEndpointInfo().getInterface().getName())
                         .append(")\n");
             }
-            log.info("JAX-WS service endpoints [{}]:\n\n{}", this.defaultPath, endpoints);
+            LOG.info("JAX-WS service endpoints [{}]:\n\n{}", this.defaultPath, endpoints);
         } else {
-            log.info("No JAX-WS service endpoints were registered.");
+            LOG.info("No JAX-WS service endpoints were registered.");
         }
     }