Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc ApplicationError fixes #410

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

sleberknight
Copy link
Member

  • Remove the synchronized keyword from the two methods that are using the Lombok Synchronized annotation, since that defeats the purpose.
  • Remove VisibleForTesting from clearPersistentHostInformation because it is used by the ApplicationErrorExtension, which here is technically production code.

* Remove the synchronized keyword from the two methods that are
  using the Lombok Synchronized annotation, since that defeats
  the purpose.
* Remove VisibleForTesting from clearPersistentHostInformation
  because it is used by the ApplicationErrorExtension, which
  here is technically production code.
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Sep 2, 2024
@sleberknight sleberknight added this to the 3.0.0 milestone Sep 2, 2024
@sleberknight sleberknight self-assigned this Sep 2, 2024
Copy link

sonarqubecloud bot commented Sep 2, 2024

@sleberknight sleberknight merged commit 3e7c7f8 into main Sep 2, 2024
5 checks passed
@sleberknight sleberknight deleted the fixes-to-ApplicationError branch September 2, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant