Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Surefire plugin to use UTC as default time zone #359

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Configure Surefire plugin to use UTC as default time zone #359

merged 1 commit into from
Feb 18, 2024

Conversation

sleberknight
Copy link
Member

  • In pom.xml set the JVM time zone to UTC when running tests
  • Log a warning in AbstractApplicationErrorDaoTest when the timestamp assertions fail, explaining that it is probably a timezone problem. This should only occur when using something other than Maven and IntelliJ to run tests, such as VSCode which doesn't apply the Surefire plugin configuration when running tests via its test runner. IntelliJ is smarter and automatically applies the configuration when running tests via its test runner.

@sleberknight
Configure Surefire plugin to use UTC as default time zone
e212fe3 
* In pom.xml set the JVM time zone to UTC when running tests
* Log a warning in AbstractApplicationErrorDaoTest when the
  timestamp assertions fail, explaining that it is probably
  a timezone problem. This should only occur when using something
  other than Maven and IntelliJ to run tests, such as VSCode
  which doesn't apply the Surefire plugin configuration when
  running tests via its test runner. IntelliJ is smarter
  and automatically applies the configuration when running
  tests via its test runner.
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Feb 18, 2024
@sleberknight sleberknight added this to the 2.1.2 milestone Feb 18, 2024
@sleberknight sleberknight self-assigned this Feb 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sleberknight sleberknight merged commit 46f13dd into master Feb 18, 2024
5 checks passed
@sleberknight sleberknight deleted the require-utc-in-tests branch February 18, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.
1 participant
@sleberknight