Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ApplicationErrorJdbc's nextOrThrow method with the one from KiwiJdbc #321

Closed
sleberknight opened this issue Nov 18, 2023 · 0 comments · Fixed by #329
Closed

Replace ApplicationErrorJdbc's nextOrThrow method with the one from KiwiJdbc #321

sleberknight opened this issue Nov 18, 2023 · 0 comments · Fixed by #329
Assignees
@sleberknight
Labels
refactoring Code refactoring
Milestone
2.1.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Nov 18, 2023 •
edited
Loading

This is blocked until:

Even though this removes a public API member, we don't need to increase the major version, because ApplicationErrorsJdbc#nextOrThrow has never been in an actual release.
@sleberknight sleberknight added the refactoring Code refactoring label Nov 18, 2023
@sleberknight sleberknight added this to the 2.1.0 milestone Nov 18, 2023
@sleberknight sleberknight self-assigned this Nov 18, 2023
@sleberknight sleberknight added blocked Blocked by another issue, PR, etc. and removed blocked Blocked by another issue, PR, etc. labels Nov 19, 2023
sleberknight added a commit that referenced this issue Nov 26, 2023
@sleberknight
Replace nextOrThrow in ApplicationErrorJdbc with one from KiwiJdbc
c900f79 
* Replace usages of ApplicationErrorJdbc#nextOrThrow with the
  one from KiwiJdbc
* Remove the nextOrThrow method from ApplicationErrorJdbc; this
  was never in an actual release so doesn't break any existing code
  and doesn't require a major version bump
* Remove the nextOrThrow tests from ApplicationErrorJdbcTest; we
  don't need to test it anymore since it's now the one in KiwiJdbc

Closes #321
@sleberknight sleberknight mentioned this issue Nov 26, 2023
Merged
sleberknight added a commit that referenced this issue Nov 26, 2023
@sleberknight
Replace nextOrThrow in ApplicationErrorJdbc with one from KiwiJdbc (#329
12b8603 
)

* Replace usages of ApplicationErrorJdbc#nextOrThrow with the
  one from KiwiJdbc
* Remove the nextOrThrow method from ApplicationErrorJdbc; this
  was never in an actual release so doesn't break any existing code
  and doesn't require a major version bump
* Remove the nextOrThrow tests from ApplicationErrorJdbcTest; we
  don't need to test it anymore since it's now the one in KiwiJdbc

Closes #321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
refactoring Code refactoring
Projects
None yet
Milestone
2.1.0
1 participant
@sleberknight