ErrorContextBuilder should only force embedded H2 databases to be DataStoreType.NOT_SHARED #306
Comments
sleberknight
added
the
enhancement
sleberknight
changed the title
sleberknight
added a commit
that referenced
this issue
Oct 26, 2023
* Add isH2EmbeddedDataStore to ApplicationErrorJdbc * Remove the erroneous implNote from isH2DataStore in ApplicationErrorJdbc; the method name tells you exactly wha it does * Change ErrorContextBuilder to force NOT_SHARED only when the data store type has already been set, and the JDBC URL in the DataSourceFactory is an H2 URL that is for an embedded connection. Closes #306
chrisrohr
pushed a commit
that referenced
this issue
Oct 30, 2023
* Only force embedded H2 databases to be NOT_SHARED * Add isH2EmbeddedDataStore to ApplicationErrorJdbc * Remove the erroneous implNote from isH2DataStore in ApplicationErrorJdbc; the method name tells you exactly wha it does * Change ErrorContextBuilder to force NOT_SHARED only when the data store type has already been set, and the JDBC URL in the DataSourceFactory is an H2 URL that is for an embedded connection. Closes #306 * Cleanup the H2 data store logic * Update isH2DataStore to check driver and URL * No need to check blank URL in isH2EmbeddedDataStore anymore since we know it must be an H2 URL by that point in the code * Introduce private isNotH2DataStore method because I just don't like reading !someThing(...) and prefer to see isNotSomeThing(...) in the main logic * Update javadocs to match new logic * IntelliJ reformatted some code, and I let it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
ErrorContextBuilder#buildWithDataStoreFactorymethod forces the data store type to beDataStoreType.NOT_SHAREDfor all H2 databases regardless of connection mode, i.e. whether using embedded mode (e.g. local file-based or in-memory) or server mode.Only embedded databases should be forced to
NOT_SHARED, since server mode H2 databases are client/server applications over TCP/IP and thus are shared.Under the covers the
buildWithDataStoreFactorymethod calls the publicApplicationErrorJdbc#isH2DataStoremethod, which only checks if the driver class isorg.h2.Driver. Since this method is public, we can't just modify its behavior in a substantial manner without a major version bump. So, a better option for now is to create a new method, e.g.isEmbeddedH2DataStore, which checks both the driver class is H2, and that the (H2) JDBC URL is one for an embedded mode database, which encompasses several types of URLs. See Database URL Overview in the H2 documentation.The private
ErrorContextBuilder#forceH2DatabaseToBeNotSharedWithWarningmethod should be renamed, and the logged warning should change "in-memory" to be "embedded" or something more generic to indicate an embedded (and thus not shared) database.The javadocs in
ErrorContextBuildershould also be updated to state that only embedded H2 databases will be automatically set toNOT_SHARED.The text was updated successfully, but these errors were encountered: