Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip registration of GotErrorsResource #289

Closed
sleberknight opened this issue Sep 15, 2023 · 0 comments · Fixed by #299
Closed

Add option to skip registration of GotErrorsResource #289

sleberknight opened this issue Sep 15, 2023 · 0 comments · Fixed by #299
Labels
enhancement A request for change or improvement to an existing feature
Milestone
2.1.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Sep 15, 2023 •
edited
Loading

Add an option in ErrorContextBuilder to skip registration of GotErrorsResource.

Not everyone wants or needs to expose this endpoint, especially since the resource is currently not secured.

Related to #290
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Sep 15, 2023
@sleberknight sleberknight added this to the 2.1.0 milestone Sep 15, 2023
@sleberknight sleberknight mentioned this issue Sep 15, 2023
Closed
@sleberknight sleberknight modified the milestone: 2.1.0 Oct 20, 2023
sleberknight added a commit that referenced this issue Oct 20, 2023
@sleberknight
Add options to skip REST resource registration
62c1059 
* Add option to skip registration of GotErrorsResource
* Add option to skip registration of ApplicationErrorResource

Closes #289
Closes #290
@sleberknight sleberknight mentioned this issue Oct 20, 2023
Merged
chrisrohr pushed a commit that referenced this issue Oct 23, 2023
@sleberknight
Add options to skip REST resource registration (#299)
a55175c 
* Add options to skip REST resource registration

* Add option to skip registration of GotErrorsResource
* Add option to skip registration of ApplicationErrorResource

Closes #289
Closes #290

* Oops, accidentally pushed code I was using to ensure tests passed!

* Add more tests for ErrorContextBuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Add options to skip REST resource registration kiwiproject/dropwizard-application-errors
1 participant
@sleberknight