Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random password for in-memory H2 database #242

Closed
sleberknight opened this issue Mar 10, 2023 · 0 comments · Fixed by #243
Closed

Use random password for in-memory H2 database #242

sleberknight opened this issue Mar 10, 2023 · 0 comments · Fixed by #243
Assignees
Labels
enhancement A request for change or improvement to an existing feature
Milestone

Comments

@sleberknight
Copy link
Member

Currently we use a hard-coded password (the horror) for in-memory H2 databases. Even though this should not be a problem, since the database is in-memory and is only accessible from within the JVM that launched it, Sonar is complaining that our "rotten tomatoes" password is compromised. 🍅

Of course, if someone is already inside a server, then there are probably much bigger problems than them getting into the in-memory database for a service which contains information about application errors that have occurred! 🤣

Anyway, since it's easy enough to generate a random password for the in-memory H2 database, let's do that and make Sonar happy. 👍

Apache Commons Lang has a lovely RandomStringUtils class that we can use to generate strings of a specific length with random (well, pseudo-random) characters.

@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Mar 10, 2023
@sleberknight sleberknight added this to the 1.2.0 milestone Mar 10, 2023
@sleberknight sleberknight self-assigned this Mar 10, 2023
sleberknight added a commit that referenced this issue Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant