Improve testing environment for whole repo #11
Conversation
.eslintrc
Outdated
| ], | ||
| "rules": { | ||
| "prettier/prettier": "error", | ||
| "prettier/prettier": [ |
There was a problem hiding this comment.
nope, use .prettierrc. also, the only rules that make sense configuring are the ones already present
.eslintrc
Outdated
| "trailingComma": "all" | ||
| } | ||
| ], | ||
| "import/no-extraneous-dependencies": "off", |
There was a problem hiding this comment.
I agree with @oreqizer . If this is causing issues in tests then use a glob pattern to fix it. https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md
There was a problem hiding this comment.
It's not working for yarn workspaces. Globs didn't help for all cases.
import-js/eslint-plugin-import#458 (comment)
.eslintrc
Outdated
| } | ||
| ], | ||
| "import/no-extraneous-dependencies": "off", | ||
| "react/jsx-filename-extension": "off", |
There was a problem hiding this comment.
I would agree with turning this off, I don't see any reason to make difference whether file has some JSX or not, it's like prefixing all string variables with s...
There was a problem hiding this comment.
Changed to .js only. I don't see benefit to use .jsx.
There was a problem hiding this comment.
well JSX is not a valid JS syntax, that's a pretty simple reason. whatever, you guys are the majority
.eslintrc
Outdated
| ], | ||
| "import/no-extraneous-dependencies": "off", | ||
| "react/jsx-filename-extension": "off", | ||
| "react/require-default-props": "off", |
.eslintrc
Outdated
| "import/no-extraneous-dependencies": "off", | ||
| "react/jsx-filename-extension": "off", | ||
| "react/require-default-props": "off", | ||
| "jsx-a11y/label-has-for": "off", |
There was a problem hiding this comment.
Added comment. Label is wrapping input, no need for for.
jakubzaba
force-pushed
the
testing-env
branch
from
eec435a to
b26da56
Compare
|
@oreqizer pls take a look on changes. |
.eslintrc
Outdated
| ], | ||
| "rules": { | ||
| "prettier/prettier": "error", | ||
| "import/no-extraneous-dependencies": "off", |
There was a problem hiding this comment.
no, see comment in the original thread (or here lol):
turn off where needed. this rule is perfectly legit
.eslintrc
Outdated
| } | ||
| ], | ||
| "import/no-extraneous-dependencies": "off", | ||
| "react/jsx-filename-extension": "off", |
There was a problem hiding this comment.
well JSX is not a valid JS syntax, that's a pretty simple reason. whatever, you guys are the majority
|
sorry for the delay, guys. yesterday was hectic |
jakubzaba
force-pushed
the
testing-env
branch
from
b26da56 to
5fe0e03
Compare
|
I added |
Add circleci Move enzyme into root package.json Add testing scripts into root package.json Turn off some eslint rules
jakubzaba
force-pushed
the
testing-env
branch
from
5fe0e03 to
2bcd53a
Compare
|
The point about working around Flow is invalid IMO, but OK, requiring all props to be defaulted would be daunting I guess |
Update List and ListItem components to support TextLinks.
Add circleci
Move enzyme into root package.json
Add testing scripts into root package.json
Turn off some eslint rules