Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.11 and make it the default while building hostpython3 and python3 #2850

Merged
merged 3 commits into from
Nov 18, 2023
Merged

Add support for Python 3.11 and make it the default while building hostpython3 and python3 #2850

merged 3 commits into from
Nov 18, 2023

Conversation

T-Dynamos
Copy link
Contributor

@T-Dynamos T-Dynamos commented Jul 8, 2023 •
edited
Loading

Closes #1866

@T-Dynamos T-Dynamos marked this pull request as ready for review July 8, 2023 06:48
@T-Dynamos T-Dynamos force-pushed the update-python branch 3 times, most recently from 27130b2 to 2b90282 Compare July 8, 2023 07:15
@misl6
Copy link
Member

misl6 commented Jul 8, 2023

Hi @T-Dynamos !

As stated here (#2798), we likely need some intermediate release before defaulting to Python 3.11

What about introducing Python 3.11 support, but keeping the default to 3.10? (we can likely change it to 3.11 after the next release)

@misl6
Copy link
Member

misl6 commented Jul 8, 2023

(If you're doing that to test it on CI runs, feel free to continue 😁)

@T-Dynamos
Copy link
Contributor Author

What about introducing Python 3.11 support, but keeping the default to 3.10? (we can likely change it to 3.11 after the next release)

Yes, Good idea!

@T-Dynamos T-Dynamos changed the title python: update to 3.11.4 python: add version 3.11 support Jul 8, 2023
@T-Dynamos T-Dynamos force-pushed the update-python branch 3 times, most recently from 296f99c to c6ab7a4 Compare July 9, 2023 12:58
@T-Dynamos
Copy link
Contributor Author

T-Dynamos commented Jul 9, 2023 •
edited
Loading

It is worth noting that updating Python to version 3.11 fixes issue #2840 (and may be others also).

Not really.

@misl6
Copy link
Member

misl6 commented Jul 22, 2023

Is still a "DO NOT MERGE, yet" or we can start a review?

@T-Dynamos
Copy link
Contributor Author

Yes we can start review.

misl6
misl6 requested changes Jul 30, 2023
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @T-Dynamos !

I left some comments that need to be addressed. Let me know when you're ready to discuss about it or to start another review.

pythonforandroid/recipes/hostpython3/patches/pyconfig_detection.patch Outdated Show resolved Hide resolved
pythonforandroid/recipes/python3/__init__.py Show resolved Hide resolved
pythonforandroid/recipes/python3/__init__.py Outdated Show resolved Hide resolved
pythonforandroid/recipes/python3/patches/py3.11.4_disable_parallel_build.patch Outdated Show resolved Hide resolved
pythonforandroid/recipes/python3/patches/py3.11.4_fix_cortex_a8.patch Outdated Show resolved Hide resolved
pythonforandroid/recipes/python3/patches/py3.7.1_fix-ctypes-util-find-library.patch Outdated Show resolved Hide resolved
pythonforandroid/recipes/python3/patches/pyconfig_detection.patch Outdated Show resolved Hide resolved
@misl6
Copy link
Member

misl6 commented Sep 10, 2023

@T-Dynamos any updates on the required changes/comments?

I'm scheduling an intermediate release for python-for-android next week, and it will be announced as the last one to default to 3.10, then we can definitely switch to 3.11 (as default)

@T-Dynamos
Copy link
Contributor Author

Ok, will do changes very soon.

@T-Dynamos T-Dynamos mentioned this pull request Sep 17, 2023
Merged
9 tasks
@misl6
Copy link
Member

misl6 commented Sep 23, 2023

I'm scheduling an intermediate release for python-for-android next week, and it will be announced as the last one to default to 3.10, then we can definitely switch to 3.11 (as default)

Hi @T-Dynamos ,

The release is out, so it's time to switch to 3.11 by default.
Can you please set the default version to 3.11 on both hostpython3 and python3 ?

@T-Dynamos
Copy link
Contributor Author

@misl6 Done!

@T-Dynamos T-Dynamos force-pushed the update-python branch 4 times, most recently from 01067cb to 89a05ba Compare September 24, 2023 12:16
@misl6
Copy link
Member

misl6 commented Oct 1, 2023

HI @T-Dynamos ,

Seems that https://github.com/kivy/python-for-android/actions/runs/6289971378/job/17076995561?pr=2850 breaks if we switch to Python 3.11, can you take a look?

@T-Dynamos T-Dynamos marked this pull request as ready for review October 30, 2023 18:21
@T-Dynamos
Copy link
Contributor Author

T-Dynamos commented Oct 31, 2023 •
edited
Loading

@misl6 Scipy build was successful, but can you check why pybind11 is now faling on mac-os? (I don't know anything about mac).

@misl6
Copy link
Member

misl6 commented Nov 3, 2023

@misl6 Scipy build was successful, but can you check why pybind11 is now faling on mac-os? (I don't know anything about mac).

Let me try on macOS!

@misl6
Copy link
Member

misl6 commented Nov 4, 2023

@misl6 Scipy build was successful, but can you check why pybind11 is now faling on mac-os? (I don't know anything about mac).

I can confirm that even pybind11==2.9.0 (the current default) fails to build via macOS, so it failed even before your changes. And I'm not even sure that the produced build fully works when built via Linux, by looking at the recipe.

So, can you please add pybind11 to this list and commit again, so we can see a clean build?

Then, before the merge I will submit a bug report regarding the pybind11 recipe, so we can track it down.

@misl6
Copy link
Member

misl6 commented Nov 4, 2023

Hi @T-Dynamos, I guess you should rebase, as we have a conflict.

@T-Dynamos T-Dynamos force-pushed the update-python branch 3 times, most recently from 175d847 to 4288ff9 Compare November 5, 2023 05:47
@T-Dynamos
Copy link
Contributor Author

Done!, But please cancel other actions triggered by it.

@T-Dynamos
Copy link
Contributor Author

Ref: #1866 (comment)

11-15 10:53:58.589 18546 18581 I python  : ctypes.__version__: 1.1.0
11-15 10:53:58.589 18546 18581 I python  : ctypes.pythonapi.PyObject_GetBuffer: <_FuncPtr object at 0xc5e64260>
11-15 10:53:58.589 18546 18581 I python  : ctypes.pythonapi.PyObject_New: <_FuncPtr object at 0xc5e8a570>

CC: @AndreMiras

@T-Dynamos T-Dynamos force-pushed the update-python branch 3 times, most recently from 120046a to daec65d Compare November 18, 2023 16:12
@misl6 misl6 changed the title python: add version 3.11 support Add support for Python 3.11 and make it the default while building hostpython3 and python3 Nov 18, 2023
misl6
misl6 approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

(The CI is failing, but not due to your fault)

@misl6 misl6 merged commit 83e74ca into kivy:develop Nov 18, 2023
19 of 31 checks passed
qtprojectorg pushed a commit to qtproject/pyside-pyside-setup that referenced this pull request Mar 13, 2024
@ShyamQt
Android Wheels: Update Python version to 3.11
722cba9 
- python-for-android target python is now upgrade to 3.11 -
  kivy/python-for-android#2850. This constrains
  us to update to 3.11 to resolve linker issues for shiboken and PySide
  binaries.
- The also helps for CI wheel creation since the Python version in our
  CI system is 3.11.
- As a drive-by remove designer plugins from Android wheels.

Task-number: PYSIDE-1612
Change-Id: I8c75d4d4567b6830e26a2d9a24db90592f6dc03d
Reviewed-by: Adrian Herrmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ctypes.pythonapi issues; getting AttributeError: undefined symbol
2 participants
@T-Dynamos @misl6