Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Update pydantic recipe #2742

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

FilipeMarch
Copy link
Contributor

There is incompatibility between python > 3.6 and package dataclasses.

This error was happening after my compilations: AttributeError: module 'typing' has no attribute '_ClassVar'

The fix is removing dataclasses from python_depends.

I also updated the pydantic version to the newest release 1.10.4, it can be checked here and its url.

I already compiled my app after applying these changes, and the compilation is working successfully again.

There is [incompatibility](huggingface/transformers#8638) between python > 3.6 and package `dataclasses`.

This error was happening after my compilations: `AttributeError: module 'typing' has no attribute '_ClassVar'`

The fix is removing `dataclasses` from `python_depends`.

I also updated the pydantic version to the newest release `1.10.4`, it can be checked [here](https://github.com/pydantic/pydantic/releases) and its url.

I already compiled my app after applying these changes, and the compilation is working successfully again.
@FilipeMarch FilipeMarch changed the title Update pydantic recipe 🐛fix: Update pydantic recipe Feb 1, 2023
@FilipeMarch FilipeMarch changed the title 🐛fix: Update pydantic recipe 🐛 fix: Update pydantic recipe Feb 1, 2023
@JRH89
Copy link

JRH89 commented Feb 1, 2023

Does any youtube-dl recipe exist?

@FilipeMarch
Copy link
Contributor Author

FilipeMarch commented Feb 1, 2023

Does any youtube-dl recipe exist?

Hello, @JRH89! You can check the list of existing p4a recipes here

But youtube-dl is not on the list. You will need to create one yourself, but you can also ask for help during the process.

@JRH89
Copy link

JRH89 commented Feb 1, 2023

Thank you @FilipeMarch

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMiras
Copy link
Member

CI mostly happy beside some unrelated issue with libsdl-org/jpeg.git cloning.
Thanks for the PR, merging

@AndreMiras AndreMiras merged commit 81f6d77 into kivy:develop Feb 1, 2023
@JRH89
Copy link

JRH89 commented Feb 2, 2023

Is this a good place to ask for help with writing a youtube-dl recipe?

@AndreMiras
Copy link
Member

The good place is on the Discord server, details in the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants