Implements --manifest-orientation and changes how --orientation works so we can now pass the setting to the SDL orientation hint
#2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so we can now pass the setting to SDL orientation hint
shyamnathp
pushed a commit
to shyamnathp/python-for-android
that referenced
this pull request
Feb 17, 2023
…orks so we can now pass the setting to the SDL orientation hint (kivy#2739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on issue #2724 , when targeting API 31 and above, on Android 12 and above, the attribute
android:screenOrientationis ignored, as the activity will run in multi-window mode.This PR takes advantage of changes made on SDL side which have been applied as a patch to
python-for-androidSDL build: #2730.After these changes, orientation can be controlled in two ways:
--orientationwill control the allowed orientations (portrait,landscape,portrait-reverse,landscape-reverse). The allowed orientations list is then set toKIVY_ORIENTATION, which is used during window setup time to populate theSDL_HINT_ORIENTATIONSvalue, as we're doing for other platforms.--manifest-orientationhas been added to keep theandroid:screenOrientationpersonalisation functionality, even if Android will be likely deprecate this attribute in future. Valid values can be find here.If
--manifest-orientationis not set, and only (one of multiple)--orientationoptions are passed, the value forandroid:screenOrientationis guessed and synthesised from the--orientationoption. Sinceandroid:screenOrientationaccepts only 1 value, if multiple--orientationare given,android:screenOrientationwill be set tounspecified.A
buildozerPR will follow.P.S. : I'm slowly changing
pythonforandroid/bootstraps/common/build/build.pyin order to make it deeply testable, so some changes may seem to be unrelated, but are needed in order to actually test the code.--orientation sensoror--orientation userare not valid anymore, and an error will be raised, and the user will be forced to migrate.