Fixes an issue regarding blacklist and bytecode compile + some cleanup #2693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building an app via
python-for-android
(without usingbuildozer
on top of it), the app may fail to build.python-for-android
refuses to build due to a python file that is located in a blacklisted folder (viablacklist.txt
) as that file is failing the byte-compile step.That should not happen, as a blacklisted folder (E.g.
venv
or.git
) may contain a python file that can't be byte-compiled.Also, byte-compiling a blacklisted folder may lead to an increase of the build time.
This PR targets the above-mentioned issue, and the following minor ones:
.pyo
filename extension is no longer used and has been removed in favour of extension.pyc
All the references to
pyo
has been removed.--no-compile-pyo
build option has been removed in favor of--no-byte-compile-python
, which doesn't refer to a specific filename extension..apk
and.aab
are not blacklisted by default. The first ever build will work, but the subsequent one will try to also include the.apk
or.aab
into the artifact. That will lead to an increase in size and a potential failure during the final gradle step.