Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload artifacts produced from every build platform, not only ubuntu-latest #2588

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Apr 24, 2022

These changes allows us to test the artefacts produced from ubuntu-latest, macos-latest and apple-silicon-m1.

Builds made on different platforms may lead to a different result. (As an example, numpy seems to pass during build-time on macos-latest, but later it fails during on-device tests).

@misl6
Copy link
Member Author

misl6 commented Apr 24, 2022

(⚠️ CI is still expected to fail on macos-latest and apple-silicon-m1)

@misl6 misl6 requested a review from AndreMiras April 24, 2022 15:04
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants