Remove stray - in output file name #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dbnicholson thanks for addressing that. git pull --rebase upstream/develop # given that the remote is called upstreamSorry that we took so long to take a look as this ended up conflicting |
The final component in the package name is just the extension, so prefixing it with a - means the output file ends in -.<ext>.
dbnicholson
force-pushed
the
package-filename
branch
from
a9c351f
to
54575ae
Compare
|
Sorry for the delay. Rebased now. It's actually nicer since the github workflow has the artifact names defined in one place in environment variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final component in the package name is just the extension, so
prefixing it with a - means the output file ends in
-.<ext>.