update sqlite3 #2449
Merged
update sqlite3 #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
approved these changes
Apr 21, 2021
| # Don't forget to change the URL when changing the version | ||
| url = 'https://www.sqlite.org/2021/sqlite-amalgamation-3340100.zip' | ||
| url = 'https://www.sqlite.org/2021/sqlite-amalgamation-3350500.zip' |
There was a problem hiding this comment.
I know it was already not working in the past, but ideally the url should be built from the version.
I think the PR is good enough, but we could follow up on that.
I think overriding the versioned_url() method should do the trick
There was a problem hiding this comment.
The year in the url isn't something we can derive from the version though :(
https://www.sqlite.org/2021/sqlite-amalgamation-3350500.zip
^^^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.