Added ability to set input type on android #2405
Conversation
|
@AndreMiras Rebased and just re-generated PR. |
| Handler commandHandler = new SDLCommandHandler(); | ||
|
|
||
| // Send a message from the SDLMain thread | ||
| - boolean sendCommand(int command, Object data) { | ||
| + protected boolean sendCommand(int command, Object data) { |
There was a problem hiding this comment.
Oh god it's so hard to read a diff of a diff, I initially tought you changed that.
You actually just removed some trailing whitespace so GitHub is showing the context which contains the previous diff, that's so confusing to read 🤯 but that's fine I'll manage
| // This is what SDL runs in. It invokes SDL_main(), eventually | ||
| protected static Thread mSDLThread; | ||
|
|
||
| + public static int keyboardInputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD; |
There was a problem hiding this comment.
So at the end the changes you made to this SDLActivity.java.patch file is only using this const and clearing some trailing whitespaces, correct or I'm missing something?
| InputMethodManager imm = (InputMethodManager) getContext().getSystemService(Context.INPUT_METHOD_SERVICE); | ||
| imm.restartInput(mTextEdit); | ||
| } | ||
| } |
There was a problem hiding this comment.
OK nice, then someone could write the Python wrapper in pythonforandroid/recipes/android/src/android/ later, correct?
If you already have done so for your project you could share the code snipped in some comments. Or better make a follow up PR after this one is merged
There was a problem hiding this comment.
Yes it could be.
This change keyboard function is being utilized kivy/kivy#7231
|
Merged, thanks for getting back to me on my questions |
This PR added ability to set input type for keyboard on android. It needs to be merged with kivy/kivy#7231
this is just a new PR with a successful rebase so the CI builds.
closes #2361