Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg and ffpyplayer improvements #2335

Merged

Conversation

rnixx
Copy link
Member

@rnixx rnixx commented Oct 15, 2020

Update versions of ffmpeg and ffpyplayer recipes.
Do not enable building of GPL components if not necessary.
Add support for x86 build in ffmpeg recipe

…ing of GPL components if not necessary. Add support for x86 build in ffmmpeg recipe
@rnixx
Copy link
Member Author

rnixx commented Oct 15, 2020

Relates to matham/ffpyplayer#100

@germn
Copy link
Contributor

germn commented Oct 16, 2020

Hello!
I was also updating these recipes recently for my project. Some dependencies for ffmpeg codecs can be updated as well.
Maybe you could pick them for this PR from this commit?
germn@d200d7f

I've tried and it seems to compile ok, also successfully checked on couple of videos.

@rnixx
Copy link
Member Author

rnixx commented Dec 7, 2020

@germn can you create a dedicated PR for updating shine and x264 recipes please?

@rnixx
Copy link
Member Author

rnixx commented Dec 7, 2020

@AndreMiras @inclement @matham

Are there any objections left on this PR? would be great if it can be merged, thanks.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the reminder @rnixx

@AndreMiras AndreMiras merged commit f19d3f7 into kivy:develop Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants