Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe: update 'cryptography' and rm unnecessary dependencies #2130

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

SomberNight
Copy link
Contributor

Update the cryptography recipe to a newer version, and remove unnecessary dependencies.

  • idna no longer needed since version 2.5
  • asn1crypto no longer needed since version 2.8
  • enum34 is just a backport of python 3.4+ functionality
  • ipaddress is just a backport of python 3.3+ functionality

(I am assuming py2 and old versions of py3 are no longer supported)

@AndreMiras
Copy link
Member

AndreMiras commented Apr 4, 2020

Thank you!
The cffi build failed and I'd like to investigate why before merging. It could simply be a missing system dependency, but I'd like to spend time on it as the error is unclear to me.
https://travis-ci.org/github/kivy/python-for-android/jobs/670789002
OK it's something to do with Python3.8 and cffi, I'll look into it later today 👍

AndreMiras added a commit to AndreMiras/python-for-android that referenced this pull request Apr 4, 2020
https://bitbucket.org/cffi/cffi/issues/403/build-fails-on-38-dev-pyinterpreterstate
kivy#2130 (comment)
The error was:
```
c/call_python.c:20:30: error: incomplete definition of type 'struct _is'
```
@SomberNight
Copy link
Contributor Author

I've only tested with python 3.7 :/

@AndreMiras
Copy link
Member

No worries, the fix was merged recently, could you try to rebase on develop to see if it helps with the build now?

- 'idna' no longer needed since version 2.5
- 'asn1crypto' no longer needed since version 2.8
- 'enum34' is just a backport of python 3.4+ functionality
- 'ipaddress' is just a backport of python 3.3+ functionality
@SomberNight
Copy link
Contributor Author

Sure, rebased now.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good thank you 😄
We had one flaky test on GitHub action due to the pyjnius patching, I've reran it, but we're good for the merge.
Thanks!

@AndreMiras AndreMiras merged commit caf9f4b into kivy:develop Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants