Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes and cleanup #2115

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Minor fixes and cleanup #2115

merged 1 commit into from
Mar 31, 2020

Conversation

AndreMiras
Copy link
Member

  • remove object inheritance
  • remove __future__ imports
  • remove six checks and conditional imports
  • flat out a few for loops
  • fix dir is a reserved keyword
  • few more nitpick fixes

opacam
opacam reviewed Mar 31, 2020
View reviewed changes
pythonforandroid/build.py Outdated
):
return True
return False
return project_dir is not None and \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: this backslash hurts my eyes 😆, since we touch the lines we could remove that and do it more 🐍.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks addressed 👍

opacam
opacam previously approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!!

@AndreMiras
Minor fixes and cleanup
22b7dfe 
- remove `object` inheritance
- remove `__future__` imports
- remove `six` checks and conditional imports
- flat out a few for loops
- fix `dir` is a reserved keyword
- few more nitpick fixes
opacam
opacam approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndreMiras AndreMiras merged commit f2b621e into kivy:develop Mar 31, 2020
@AndreMiras AndreMiras deleted the feature/minor_fixes branch March 31, 2020 11:28
@AndreMiras AndreMiras mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opacam opacam opacam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreMiras @opacam