-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap backend for Android Library project #1963
base: develop
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,113 @@ | |||
package {{ args.package }}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this file is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains code for setting service properties (like its entry point) and code for unpacking python bundle. I'm not sure that it is needed, but I don't know how to do these things without it.
I'm not clear from the code alone, what exactly is new/different in this bootstrap compared to (say) the service_only one? Would it be possible to make the aar thing a build option instead of a bootstrap? |
The main difference is that in For I think it is possible to make it a build option for |
Thanks for the clarifications @xuhcc. My current thinking is that this would be preferable to add as functionality to one or more existing bootstraps, and to call it using a new |
Added new bootstrap backend for packaging python service as Android library.
Resolves #1957
I'm not familiar with python-for-android codebase, so I tried to keep changes to existing modules to a minimum. Some files (e.g. jtar classes) are simply copied from the service_only bootstrap. I'm not sure what's the best approach here. Maybe we can move them to
bootstraps/common
?