Release 2019.07.08 #1909
Merged
Release 2019.07.08 #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unittest for module `pythonforandroid.archs`
Replaced one of the python2 travis builds with python3 arm64-v8a
Merge release-2019.06.06 to develop
This means that pypi renders the README correctly
Merge 2019.06.06.post0 hotfix: set long_description_content_type in setup.py
Improved release model documentation
bugfix: unpack for nonzip archives also needs to compare basename(dir)
Make sure the pythonpackage functions return an error when someone attempts to do so anyway
Add unittest for module `pythonforandroid.distribution`
pythonpackage can't return build requirements for wheels, make it return an error if attempted
To fix freetype build for `openSUSE` and maybe other oses. Note: It seems that there is a bug in `bzip2-devel` for debian and derivatives which are distributed without a `pkg-config` file, so when we compile freetype with a debian os (or derivative) we build it without bzip2 support, so we enforce to disable bzip2 support, because we know that freetype works fine without bzip2 support Resolves: #1854
Add `--without-bzip2` to freetype's configure args
Fix locating system python when it's not in $PATH (weird but happens, apparently)
Because we make use of some mock methods in module `test_util` (eg: `mock.assert_called_once`) which were introduced in python 3.6, so if the system python of the test system is lower than 3.6, then the tox tests will fail
Verifying the number of calls we made to some functions: - test_folder_exist - test_delete
…ggestions Reviewers suggestions are: - Remove forgotten debug code - `style code` change for `test_current_directory_exception` - add test `mock_shutil_rmtree.assert_not_called()` for `test_temp_directory` Also changed some lines that shouldn't be split (because are pep8 friendly without breaking it in multiple lines)
- fix file litter of constraint.txt - fix --private relative paths during build.py's setup.py install - fix "" and "." not being recognized as folder by pythonpackage.py
…tage Because we only need those dependencies for our `tox` tests so we may speed up a little the overall CI tests timings. We also remove all the other apt commands performed in `before_install` because we don't need it. Note: in order to successfully pass the test `test_pythonpackage_basic.test_virtualenv`, we need to deactivate the system virtualenv See also: travis-ci/travis-ci#8589
fix ctypes-util-find-library issue for python2
Add unittest for module `pythonforandroid.bootstrap`
Fix `run_pymodules_install` when `project_dir` isn't supplied
Undid unnecessary parts of 1.16.4 recipe change Fully replaced numpy 1.15.1 patches with 1.16.4 patches Removed git commit info from patches
Regression test for the fix introduced in #1898.
#1900 logs failure
…ules_install_regression_test Simple run_pymodules_install test, refs #1898
Updated numpy recipe to version 1.16.4
|
Is the release / what needs to be tested on the Edit: oh right I guess just literally test this actual pull request / the branch it is on? I'm not 100% sure yet how the release thing works 😂 |
|
Yep, releasing means merging develop into master, so this pr is what needs testing. Sorry, you're right that it wasn't clear. |
|
Ah, my last reply was by email and I didn't realise I messed up the PR - now changed to merge into master and so showing all the different commits. |
|
I checked some of the release steps (and updated the main post):
Here are the tox results: |
|
Awesome! |
|
@AndreMiras Great, I've just finished the tests and am looking to merge as soon as travis is happy, but I'll wait for your confirmation too. |
|
arm64-v8a build failed for some reason, I've restarted it. |
Too bad, what was the error? Anything known and already listed here #1306 ? |
|
It was a failure patching pyjnius I think, I didn't look that closely. |
|
Rings the bell, as if it was downloading/cloning the wrong version of pyjnius and then fails at patching it 🤔 |
|
Passed this time, release merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't had much time to look at PRs and issues for a few days, but I can't forget the regular scheduled release :p
If anyone is able to check any of the release steps, feel free to mark them off here.
Release checklist
Check that the build is passing
Run the tests locally via
tox: this performs some long-running tests that are skipped on Travis.Build and run the on_device_unit_tests app using buildozer. Check that they all pass.
Build and run the following testapps for arch
armeabi-v7aandarm64-v8a:python3 setup_testapp_python3_sqlite_openssl.py apkarmeabi-v7aarm64-v8apython3 setup_testapp_python2.py apkarmeabi-v7aarm64-v8aCheck that the version number is correct