-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the tox jobs run in parallel &... #1864
Conversation
Because we changed the git flow and now our main branch is `develop`
@@ -23,8 +23,8 @@ env: | |||
|
|||
jobs: | |||
include: | |||
- stage: lint | |||
name: "Tox tests and coverage" | |||
- &linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we apply the same technique that we use in the test
stage, explained here
@@ -45,6 +45,14 @@ jobs: | |||
- tox -- tests/ --ignore tests/test_pythonpackage.py | |||
# (we ignore test_pythonpackage.py since these run way too long!! | |||
# test_pythonpackage_basic.py will still be run.) | |||
name: "Tox Pep8" | |||
env: TOXENV=pep8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we use a tox feature, explained here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Also move from branch
master
todevelop
our travis file git commandsMake the tox jobs run in parallel will decrease the timings of the lint stage considerably (from ~5' to ~3'). Also, Making the jobs run in parallel will allow us to split the log output for each test, so it will be easier to find the problem, if any