Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for the problem with decorator run_on_ui_thread and the local ref… #1830

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

oukiar
Copy link
Contributor

@oukiar oukiar commented May 31, 2019

This is a workaround for solve the error of "local reference table overflow" that appears when you run multiple times functions with the decorator @run_in_ui_thread.

@ghost
Copy link

ghost commented Jun 10, 2019

Nice, thanks for helping out with this fix!

I have one suggestion: would you mind adding a comment at some place, e.g. line 53 before if f not in __functionstable__:, that gives a very brief reasoning why this helps? Unless this is obvious to everybody else, but to me it's not 100% clear right now why that code helps (and having a basic understanding of that might be useful next time someone needs to touch it)

@inclement
Copy link
Member

This looks good to me, thanks @oukiar , I'll add the comment @Jonast suggests and make the change.

@inclement inclement merged commit 7c11148 into kivy:develop Mar 30, 2020
@inclement
Copy link
Member

Hmm, sorry, didn't realise it adds that co-authored message in, my change was trivial. I'll remove that in any future generated messages.

zworkb pushed a commit to zworkb/python-for-android that referenced this pull request Apr 15, 2020
kivy#1830)

* fix for the problem with decorator run_on_ui_thread and the local reference table overflow

* Added comment about why we cache function references

Co-authored-by: Alexander Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants