Ignores Python 2 import_recipe() warnings #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Apr 7, 2019
Python 2 raises warnings on `imp.load_source()` when the module name contains dots. Ignoring this warning makes p4a output/logs more readable. Also refactors to make the code more readable. Note that for some reason the regression test will only catch the regression if ran isolated, e.g. via: ```sh tox -e py27 -- tests/test_recipe.py::TestRecipe::test_import_recipe ```
AndreMiras
force-pushed
the
feature/filter_python2_import_recipe_warnings
branch
from
91a22ee
to
7b21c46
Compare
inclement
approved these changes
Apr 7, 2019
|
Thanks! |
|
@AndreMiras nice work ❤️ for what it's worth, I get the mixed concerns but I'm also having the impression it's better to refactor it while you add something rather than not at all (which seems to be a bigger problem with a project of this size, just the nature of the economics) - so I think it's reasonable to put that in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2 raises warnings on
imp.load_source()when the module name contains dots. Ignoring this warning makes p4a output/logs more readable.Note that for some reason the regression test will only catch the regression if ran isolated, e.g. via: