Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix configure for python's recipes when building from macOS #1682

Closed
wants to merge 1 commit into from

Conversation

opacam
Copy link
Member

@opacam opacam commented Feb 6, 2019

This is a long shot

This pr is made in order to try to solve the linkage problems that we have when using a macOS as a host system.

Here I migrate a macOS's patch from python2legacy's recipe that we need in order to successfully link when building from a macOS. I suspect that we still may need that for the new python recipes...so ...I think that this pr may solve the linkage problems that we currently have, described in here #1647.

Unfortunately I couldn't test this (I haven't a macOS to test it)...so...

this should not be merged unless we can confirm that actually solves the problem

This should solve the linkage problems with libpythonX.X.so that we have when we Build from a darwin platform

Note: The added patches are migrated from the python2legacy recipe to match the new python version
@inclement
Copy link
Member

Thanks @opacam, this is great to have to point people at.

@dpProjectBuzz
Copy link

I am busy testing the solution now.

The error which I am receiving is the same as before and after applying the solution.

Although I must admit that I am very new to c++ and .mk syntax

OS=Mojave
Python_m=3

--------------------CONSOLE DUMP--------------
The ++clang missing link error

Some warnings and things.

STDOUT:
Android NDK: WARNING
/buildozer/android/platform/build/build/bootstrap_builds/sdl2-python3/jni/application/src/Android.mk:main: non-system libraries in linker flags: -lpython3.7m
Android NDK: This is likely to result in incorrect builds. Try using LOCAL_STATIC_LIBRARIES
Android NDK: or LOCAL_SHARED_LIBRARIES instead to list the library dependencies of the
Android NDK: current module

@inclement inclement changed the base branch from master to develop June 6, 2019 20:40
opacam added a commit to opacam/python-for-android that referenced this pull request Aug 2, 2019
It turns out that the generated binary for MacOS is not `python`...its `python.exe`

See also: https://github.com/python/cpython/blob/3.7/README.rst#build-instructions

Closes: kivy#1817
Closes: kivy#1800
Closes: kivy#1682
Closes: kivy#1647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants