-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin #1681
Origin #1681
Conversation
numpy/opencv fails with latest p4a at runtime (import) kivy#1678
libtribler has a dependency to pil where I read somewhere that it doesn`t build with python3. So I added this conflicts value. With openssl I had an issue to run "p4a recipes". And here probably the conflicts entry was overkill. So it`s worth a try without the conflicts entry. I can test this evening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Actually, for the modules that specified a single python version it is sufficient to take out all the references to python so then any will work, would you mind making that change?
Removed unnecessary hostpython*
Removed unnecessary hostpython*
Removed unnecessary python*
Removed unnecessary python*
Removed conflicts because it was wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now thanks!
I'll squash and merge once Travis build is done and green.
Geek-tip for later: try to squash yourself and use meaningful commit message
Build is green on core recipes, plus conditional build see below relevant part of the log:
See detailed log here: https://travis-ci.org/kivy/python-for-android/jobs/489999998 Since all comments got addressed @inclement I hope you don't mind if I dismiss your review as it seems to be blocking the merge. The PR is not touching critical components anyway |
Well actually I won't dismiss because it's presented like it would delete the comments. |
Thanks! |
Changed further recipes so other errors than no valid dependency graph will occur