Fix zope_interface and add python3 compatibility #1677
Conversation
|
Perhaps a better idea would be to just create an empty patch for that file, so that we don't do more tricky stuff within the recipe. If/after they fix it, we will get a conflict for applying patch and will know that everything is ok on their side. |
|
Oh yes, @KeyWeeUsr, a lot better with a patch, thanks!! |
opacam
changed the title
The `zope.interface` module lacks of the __init__.py file in one of his folders, that leads into an ImportError: No module named zope.interface
opacam
force-pushed
the
fix-zope-interface
branch
from
a876468
to
b938e59
Compare
|
Tried this patch with python2 and it worked for me! |
opacam
changed the title
| # Here we intentionally apply a patch to solve that, so, in case that | ||
| # this is solved in the future an error will be triggered | ||
| zope_install = join(self.ctx.get_site_packages_dir(arch.arch), 'zope') | ||
| self.apply_patch('fix-init.patch', arch.arch, build_dir=zope_install) |
There was a problem hiding this comment.
Minor: I'm not sure I understand why we're applying the patch that way rather than adding it to the patches list?
There was a problem hiding this comment.
Because the patch is apllied into the site-packages directory after the installation is made.
The patches are applied before the installation...and if you check the source code of zope.interface, you will se that the __init__.py file is in there, but when we install the package the file isn't installed...
There was a problem hiding this comment.
ahah fun, thanks for the explanation!
Then is it not the manifest file or something like that we want to fix with a patch?
I mean the way you did seems fine, I'm just challenging to see if there're no better ways
The
zope.interfacemodule lacks of the__init__.pyfile in one of his folders, that leads into:ImportError: No module named zope.interface