Fix hardcoded entries (build platform) for core modules: archs and python #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make easier for us to remove the hardcoded entries that we have in our build system
inclement
approved these changes
Jan 27, 2019
|
Seems @OptimusGREEN verified this works on macOS, so looks good. Thanks! |
|
Yup, got me past that error, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the hardcoded entries for
build platformthat we still have in some of our core modules (arch and python). This should make possible to successfully build an apk from a macos...but I cannot confirm this.Note: we still have some hardcoded entries regarding the
build platformin some recipes...