[CORE UPDATE - PART V] Fix pycrypto #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity) Since the recent openssl upgrade this recipe stopped to work. Here we adapt the recipe to the new python2 build system and to new openssl version. Also bump the recipe version number to the latest available (to avoid possible errors with our python3).
6 tasks
AndreMiras
previously approved these changes
Jan 15, 2019
There was a problem hiding this comment.
Thanks @opacam it seems good to me. I guess the WIP status was because it was waiting for the core update right?
|
No @AndreMiras, look at the LDFLAGS...I pass libraries in there instead of doing that in LIBS (for openssl)...let me fix that please!...all the other cryptography recipes of my prs (all those with status WIP) may have the same issue, be careful with that!! |
|
Now should be fine 😄 |
opacam
changed the title
Because this is how you are supposed to do it, you must use LDFLAGS for linker flags and LDLIBS (or the equivalent LOADLIBES) for the libraries
opacam
force-pushed
the
python-core-pycrypto
branch
from
3e7b898
to
de4c4c5
Compare
AndreMiras
approved these changes
Jan 15, 2019
|
Merged 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one more part for the pr #1537 (discussed previously in #1460 and #1534)
Here I fix pycrypto to make it work with the core-update pull request, which also contains a new version of the openssl libs. I Also update pycrypto to latest version and grants compatibility for both versions of python.
Note: this has to be merged only when the core-update has been merged because it depends on the new python2 recipe and the openssl libs (1.1)