-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify build.py contents #1524
Unify build.py contents #1524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like that actually makes it hard to extend with new bootstraps or update existing one.
Would it not be better approach to have some common logic somewhere and slight specific overriding changes in specific bootstraps?
Like using specialisation inheritance, would it make sense?
That definitely would make sense. (I like the idea of inheritance! Have been thinking about it as well) However, similarly to the common bootstrap area merge request which could have incorporated this but didn't, I personally prefer to go about this in multiple separate requests. While I agree it looks a bit messy with the conditionals, it is IMHO still a lot easier to do changes now, given it's at least in one central obvious place of what the bootstrap differences are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for another great contribution 🍻
This unifies the different build.py files to get the different options in sync, and make it easier to expand them without all the duplicate code.
Tested it, and it works fine with my app /
sdl2
bootstrap!