symlink system Python to hostpython3crystax build dir #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2018
AndreMiras
added a commit
to AndreMiras/python-for-android
that referenced
this pull request
Apr 1, 2018
Makes sure the arm cross linker is being used for LDSHARED. Fixes configure script complaining about CFLAGS and LDFLAGS and simplified `gevent.patch` (less is more), since flags are now sanitized during `get_recipe_env()` call. Also depends on kivy#1249 (symlink system Python to hostpython3crystax).
AndreMiras
force-pushed
the
feature/ticket1154_hostpython3crystax_build_dir_and_synlink
branch
from
5c0f96f
to
d160fae
Compare
Creates an empty hostpython3crystax build directory and symlinks system python3 to it, fixes kivy#1154
AndreMiras
force-pushed
the
feature/ticket1154_hostpython3crystax_build_dir_and_synlink
branch
from
d160fae
to
066f735
Compare
AndreMiras
deleted the
feature/ticket1154_hostpython3crystax_build_dir_and_synlink
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an empty hostpython3crystax build directory and symlinks
system python3.5 to it, fixes #1154
The idea is to create the build directory that's been used by
builddir = join(dirname(self.hostpython_location), 'build')(pythonforandroid/recipe.py).So yes this might be a bit hacky, but doesn't alter the existing code base too much and it works like a charm :)