Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusting for windows. #1235

Closed
wants to merge 5 commits into from
Closed

adjusting for windows. #1235

wants to merge 5 commits into from

Conversation

alensiljak
Copy link

@alensiljak alensiljak commented Feb 10, 2018

Python 3.6
The only (known) item left to solve is how to check for required libs in toolchain.py.

This solves #1232 and #1234.
p4a runs and shows the argument info.

Requires further testing.

Alen Siljak added 4 commits February 10, 2018 23:10
The only item left to solve is how to check for required libs in toolchain.py.
@alensiljak
Copy link
Author

alensiljak commented Feb 10, 2018

Now I'm getting [WARNING]: Asked to compile for no Archs, so failing. when calling

p4a apk --private ../. --package=org.example.myapp --name "My WebView Application" --version 0.1 --bootstrap=webview --requirements=flask --port=5000 --arch=armeabi-v7a 

@inclement
Copy link
Member

inclement commented Feb 11, 2018

Instead of copying the sh import error catching everywhere, I think it would be methodologically better to put it in one place (a new p4a file) and then every other file can import it from there.

That said, I don't think there's much point in doing this unless p4a is changed to actually work on windows, doing something like #994 (filling in all the gaps so it actually works, polishing it, and supporting it post-merge). Barring that, I think it would be better to detect the windows environment and exit with an error message before even trying the imports.

Thanks for the PR, but for these reasons I won't merge these changes.

@inclement inclement closed this Feb 11, 2018
@alensiljak
Copy link
Author

alensiljak commented Feb 11, 2018

Thanks for the feedback. Having that clearly stated somewhere in the ReadMe would have saved me (and perhaps others) significant time and effort which could have been contributed to other projects.

I will try to work off #994 and see if something can be done.
Having a Flask application with a WebView client would be a great option for a multiplatform app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants