Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix packaging failure when user has large UID by using GNU format over USTAR format #1015

Merged
merged 1 commit into from
Mar 4, 2017
Merged

Fix packaging failure when user has large UID by using GNU format over USTAR format #1015

merged 1 commit into from
Mar 4, 2017

Conversation

pts-dorianpula
Copy link

@pts-dorianpula pts-dorianpula commented Feb 24, 2017 •
edited
Loading

Fix for issue #1013

@pts-dorianpula pts-dorianpula changed the title Change to use GNU format over USTAR format, to avoid issues with large user IDs. Fix packaging failure when user has large UID by using GNU format over USTAR format Feb 24, 2017
@inclement
Copy link
Member

Well, seems to work, so let's got for it. Thanks a lot!

@inclement inclement merged commit a56784d into kivy:master Mar 4, 2017
@inclement inclement mentioned this pull request Mar 4, 2017
Closed
inclement added a commit that referenced this pull request Mar 4, 2017
@inclement
Revert "Merge pull request #1015 from pts-dorianpula/issue-1013-fix-t…
395c7e0 
…arfile-large-user-id-failure"

This reverts commit a56784d, reversing
changes made to b2e5bc3.

The reason for the revert is that although this PR seemed to work, it
actually causes problems with the tar extraction for very long
filenames.
@inclement
Copy link
Member

inclement commented Mar 4, 2017 •
edited
Loading

Unfortunately I found what seems to be a major problem with this shortly after merging, it causes problems when extracting long filenames (at least, I think it's the long filename that's the issue), as in the example below. The files here don't actually need to be there, but it's quite problematic that this could be accidentally triggered.

I've reverted this for now, pending further analysis, hopefully there is some alternative set of options or way to avoid using the uid that we can use.

03-04 22:21:26.267 15657 15684 V python  : extracting crystax_python/site-packages/kivy/input/providers/androidjoystick.py
03-04 22:21:26.267 15657 15684 V python  : extracting crystax_python/site-packages/kivy/input/providers/linuxwacom.py
03-04 22:21:26.268 15657 15684 V python  : extracting crystax_python/site-packages/kivy/input/providers/__init__.py
03-04 22:21:26.268 15657 15684 V python  : extracting crystax_python/site-packages/kivy/input/providers/tuio.py
03-04 22:21:26.269 15657 15684 V python  : extracting crystax_python/site-packages/kivy/extras/
03-04 22:21:26.269 15657 15684 V python  : extracting crystax_python/site-packages/kivy/extras/highlight.py
03-04 22:21:26.269 15657 15684 V python  : extracting crystax_python/site-packages/kivy/extras/__init__.py
03-04 22:21:26.270 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/
03-04 22:21:26.271 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/kinect/
03-04 22:21:26.271 15657 15684 V python  : extracting ././@LongLink
03-04 22:21:26.271 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/kinect/kinec
03-04 22:21:26.272 15657 15684 V python  : extracting ././@LongLink
03-04 22:21:26.272 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/kinect/READM
03-04 22:21:26.272 15657 15684 V python  : extracting ././@LongLink
03-04 22:21:26.273 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/miscellaneou
03-04 22:21:26.273 15657 15684 V python  : extracting ././@LongLink
03-04 22:21:26.273 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/miscellaneou
03-04 22:21:26.275 15657 15684 E python  : could not open /data/user/0/org.test.testapp_python3/files/app/crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/miscellaneou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pts-dorianpula @inclement @dorianpula