Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a space for common bootstrap code along with a base class for all bootstraps #988

Closed
kollivier opened this issue Jan 18, 2017 · 2 comments
Closed

Create a space for common bootstrap code along with a base class for all bootstraps #988

kollivier opened this issue Jan 18, 2017 · 2 comments

Comments

@kollivier
Copy link
Contributor

Currently, each backend has a completely separate tree of Java classes for initialzing the bootstrap, although a significant amount of the code is sharable among the backends. We should create a single place for this common code and refactor the bootstraps to use them rather than duplicate them.
kollivier added a commit to kollivier/python-for-android that referenced this issue Jan 23, 2017
@kollivier
Start on a common area for bootstraps, so that different bootstraps c…
257d712 
…an share common code. This is a first step to fixing issue kivy#988.
@kollivier kollivier mentioned this issue Jan 23, 2017
Closed
@AndreMiras
Copy link
Member

Thanks for tracking the issue and thanks for the pull request. I was actually discussing this in the group recently https://groups.google.com/forum/#!topic/kivy-dev/MvAzPilialw
We'll take a look at he PR 👍

AndreMiras added a commit to kollivier/python-for-android that referenced this issue Sep 27, 2018
@AndreMiras
Common bootstrap to be shared across bootstraps
f42f4c0 
This is the first step to fix DRY across bootstraps, refs kivy#988
AndreMiras pushed a commit to kollivier/python-for-android that referenced this issue Sep 27, 2018
@kollivier @AndreMiras
Common bootstrap to be shared across bootstraps
f307718 
This is the first step to fix DRY across bootstraps, refs kivy#988
AndreMiras pushed a commit to kollivier/python-for-android that referenced this issue Sep 27, 2018
@kollivier @AndreMiras
Common bootstrap to be shared across bootstraps
4e55085 
This is the first step to fix DRY across bootstraps, refs kivy#988
@inclement
Copy link
Member

Closing as work along these lines has been merged thanks to various contributors :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AndreMiras @kollivier @inclement