Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipes: add new materialyoucolor recipe #898

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

T-Dynamos
Copy link
Contributor

Closes #895

@mrwulff
Copy link

mrwulff commented Mar 14, 2024

(venv) kevinwulff@Kevins-MacBook-Air 3 % toolchain build materialyoucolor

[INFO ] Building with 8 processes, where supported

[INFO ] Want to build ['materialyoucolor']

[INFO ] Using the bundled version for recipe 'materialyoucolor'

[INFO ] Loaded recipe materialyoucolor (depends of ['setuptools'], optional are [])

[INFO ] Using the bundled version for recipe 'setuptools'

Traceback (most recent call last):

File "/Users/kevinwulff/3/venv/bin/toolchain", line 8, in

sys.exit(main())

File "/Users/kevinwulff/3/venv/lib/python3.10/site-packages/kivy_ios/toolchain.py", line 1670, in main

ToolchainCL()

File "/Users/kevinwulff/3/venv/lib/python3.10/site-packages/kivy_ios/toolchain.py", line 1407, in init

getattr(self, args.command)()

File "/Users/kevinwulff/3/venv/lib/python3.10/site-packages/kivy_ios/toolchain.py", line 1483, in build

build_recipes(args.recipe, ctx)

File "/Users/kevinwulff/3/venv/lib/python3.10/site-packages/kivy_ios/toolchain.py", line 1201, in build_recipes

recipe = Recipe.get_recipe(name, ctx)

File "/Users/kevinwulff/3/venv/lib/python3.10/site-packages/kivy_ios/toolchain.py", line 1064, in get_recipe

mod = importlib.import_module(f"kivy_ios.recipes.{name}")

File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/init.py", line 126, in
import_module

return _bootstrap._gcd_import(name[level:], package, level)

File "", line 1050, in _gcd_import

File "", line 1027, in _find_and_load

File "", line 1004, in _find_and_load_unlocked

ModuleNotFoundError: No module named 'kivy_ios.recipes.setuptools'

getting an error when trying to install

@subhashsharma
Copy link

@T-Dynamos - I have the same issue with your Recipe. I tried the below Recipe:

from kivy_ios.toolchain import CythonRecipe

class MaterialyoucolorRecipe(CythonRecipe):
    version = "master"
    url = "https://github.com/T-Dynamos/materialyoucolor-python/archive/{version}.zip"
    depends = ["python3"]
    archs = ["x86_64"]

recipe = MaterialyoucolorRecipe()

But I get the same SSL CERTIFICATE error which I am yet to resolve in my Mac's Python env.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the recipe and the materialyoucolor lib 🙏
Would you mind making the linter happy so we get past next step of building that recipe from the CI?

kivy_ios/recipes/materialyoucolor/__init__.py:3:1: E302 expected 2 blank lines, found 1
kivy_ios/recipes/materialyoucolor/__init__.py:8:1: E305 expected 2 blank lines after class or function definition, found 1

@T-Dynamos
Copy link
Contributor Author

Huh?, I don't understand:

Nothing to do. No updated recipes.

AndreMiras added a commit that referenced this pull request Mar 16, 2024
For some reason the git diff command was no longer returning a list, refs:
#898 (comment)
@AndreMiras
Copy link
Member

Thanks for catching it, I'm addressing it in #900
Let's wait for it to be reviewed/merged so we can rebase yours on top

misl6 pushed a commit that referenced this pull request Mar 16, 2024
For some reason the git diff command was no longer returning a list, refs:
#898 (comment)
@misl6
Copy link
Member

misl6 commented Mar 16, 2024

#900 has been merged.

@T-Dynamos and @AndreMiras, feel free to rebase / complete the review, I will keep #899 in pending until this PR is merged, and rebase on top of it at the end.

@misl6
Copy link
Member

misl6 commented Mar 16, 2024

@T-Dynamos seems you left a few things with unresolved merges.

@T-Dynamos
Copy link
Contributor Author

@misl6 :) Solved.

@T-Dynamos
Copy link
Contributor Author

Seems there are some errors, I will fix them and re-request review.

@T-Dynamos
Copy link
Contributor Author

Sorry I am new to IOS, Is there any c++_shared lib in IOS?, as I use this in android:

stl_lib_name = "c++_shared"

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy, thanks for all the follow ups.
And I appreciate the squashing 🙏

@AndreMiras AndreMiras merged commit bc58062 into kivy:master Mar 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Materialyoucolor-python Recipe
5 participants