-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recipes: add new materialyoucolor
recipe
#898
Conversation
(venv) kevinwulff@Kevins-MacBook-Air 3 % toolchain build materialyoucolor [INFO ] Building with 8 processes, where supported [INFO ] Want to build ['materialyoucolor'] [INFO ] Using the bundled version for recipe 'materialyoucolor' [INFO ] Loaded recipe materialyoucolor (depends of ['setuptools'], optional are []) [INFO ] Using the bundled version for recipe 'setuptools' Traceback (most recent call last): File "/Users/kevinwulff/3/venv/bin/toolchain", line 8, in
File "/Users/kevinwulff/3/venv/lib/python3.10/site-packages/kivy_ios/toolchain.py", line 1670, in main
File "/Users/kevinwulff/3/venv/lib/python3.10/site-packages/kivy_ios/toolchain.py", line 1407, in init
File "/Users/kevinwulff/3/venv/lib/python3.10/site-packages/kivy_ios/toolchain.py", line 1483, in build
File "/Users/kevinwulff/3/venv/lib/python3.10/site-packages/kivy_ios/toolchain.py", line 1201, in build_recipes
File "/Users/kevinwulff/3/venv/lib/python3.10/site-packages/kivy_ios/toolchain.py", line 1064, in get_recipe
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/init.py", line 126, in
File "", line 1050, in _gcd_import File "", line 1027, in _find_and_load File "", line 1004, in _find_and_load_unlocked ModuleNotFoundError: No module named 'kivy_ios.recipes.setuptools' getting an error when trying to install |
@T-Dynamos - I have the same issue with your Recipe. I tried the below Recipe:
But I get the same SSL CERTIFICATE error which I am yet to resolve in my Mac's Python env. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the recipe and the materialyoucolor lib 🙏
Would you mind making the linter happy so we get past next step of building that recipe from the CI?
kivy_ios/recipes/materialyoucolor/__init__.py:3:1: E302 expected 2 blank lines, found 1
kivy_ios/recipes/materialyoucolor/__init__.py:8:1: E305 expected 2 blank lines after class or function definition, found 1
Huh?, I don't understand:
|
For some reason the git diff command was no longer returning a list, refs: #898 (comment)
Thanks for catching it, I'm addressing it in #900 |
For some reason the git diff command was no longer returning a list, refs: #898 (comment)
#900 has been merged. @T-Dynamos and @AndreMiras, feel free to rebase / complete the review, I will keep #899 in pending until this PR is merged, and rebase on top of it at the end. |
@T-Dynamos seems you left a few things with unresolved merges. |
@misl6 :) Solved. |
Seems there are some errors, I will fix them and re-request review. |
Sorry I am new to IOS, Is there any stl_lib_name = "c++_shared" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is happy, thanks for all the follow ups.
And I appreciate the squashing 🙏
Closes #895