-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matplotlib recipe #858
matplotlib recipe #858
Conversation
FWIW, that screenshot is from my iphone, and not a simulator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff, thanks for the PR and for addressing some of the comments and CI issues already.
Great progress overall.
CI is failing with:
2023-09-09T19:46:09.5904620Z [DEBUG ] error: command '/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/tools/cpplink' failed: No such file or directory
refs https://github.com/kivy/kivy-ios/actions/runs/6131086632/job/16643997732?pr=858
If I had to guess I would say cpplink
should be added to the MANIFEST.in
.
I've also gave some ideas to help with cpplink readability, let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing.
Will merge after the build_updated_recipes build turns green
Looks like I needed to include some template files in the Manifest. These were brought over from p4a. |
Great that you saw it too, thanks for addressing already.
I'll be away from keyboard until tomorrow UTC to review/merge. |
I think I found the last issue in getting the right include file for numpy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI happy well done 👏
Thanks for the quick follow up
Thanks so much for your help in getting this reviewed and accepted. |
Resolves issue #712 and issue #857
Successfully builds matplotlib and its dependency kiwisolver. Leverages existing recipes for numpy, freetype, etc.
Takes care of all known duplicate symbol issues. Meets pep8 requirements.
To build:
screenshot when integrated with my application: