Add support for image and link URL rewriting #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm it might be better to do this as a dyn trait instead of a naked callback. |
|
Much cleaner now and no longer requires Mutex. |
liamwhite
force-pushed
the
rewriter
branch
4 times, most recently
from
fae1aa2
to
6ed2455
Compare
|
Awesome, LGTM! I am not fully across how (Ref)UnwindSafe work, but I can see that it's required to have the trait Sync/Send. THanks so much! |
|
RefUnwindSafe is a weaker assertion than Sync; every type that is Sync should also imply RefUnwindSafe, it is filed upstream issue that it is not. If you remove it you will see that the tests do not compile due to a problem with catch_unwind. |
Indeed, that's exactly what I tried, just to see what kinds of things happened without. Thanks for the link to the upstream issue, that's handy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for stateful URL rewriting during HTML generation. I attempted to follow the
broken_link_callbackin ParseOptions as an example, but needed to wrap the type because there isn't a blanket implementation for Debug on dyn Fn.