Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade style-loader to v0.21.0 to enable HMR for css modules #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

holtat
Copy link

@holtat holtat commented Jul 27, 2018

I've upgraded style-loader to address issue #144 where using CSS modules would not allow for HMR.

Here is the PR that was merged to allow for CSS modules to work with HMR on style-loader for reference: webpack-contrib/style-loader#298

I don't know of any breaking changes this update would cause.

@holtat
Copy link
Author

holtat commented Jul 27, 2018

It looks like this package is out of date on the master branch of create-react-app as well, but up to date on the next branch.

I'm not sure what's preferred. Should I try to update this fork with the next branch of create-react-app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants