Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): incorrect handling of svc tag #7

Merged
merged 12 commits into from
Mar 31, 2023
Merged

fix(*): incorrect handling of svc tag #7

merged 12 commits into from
Mar 31, 2023

Conversation

baiyutang
Copy link
Collaborator

@baiyutang baiyutang commented Mar 25, 2023 •
edited
Loading

Fix: #6

  • fix the bug of tag handling
  • upgrade kitex version
  • makefile optimizing
  • unit test

image

@bytedance-oss-robot bytedance-oss-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2023
felix021
felix021 reviewed Mar 27, 2023
View reviewed changes
consul_registry.go Outdated Show resolved Hide resolved
ppzqh
ppzqh reviewed Mar 27, 2023
View reviewed changes
consul_resolver.go Outdated Show resolved Hide resolved
ppzqh
ppzqh reviewed Mar 27, 2023
View reviewed changes
consul_registry.go Outdated Show resolved Hide resolved
felix021
felix021 reviewed Mar 27, 2023
View reviewed changes
consul_resolver.go Outdated Show resolved Hide resolved
felix021
felix021 reviewed Mar 30, 2023
View reviewed changes
consul_resolver.go Outdated Show resolved Hide resolved
@baiyutang baiyutang requested a review from ppzqh March 31, 2023 02:47
@GuangmingLuo GuangmingLuo merged commit b727d6d into kitex-contrib:main Mar 31, 2023
@bytedance-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baiyutang, felix021, GuangmingLuo, ppzqh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppzqh ppzqh ppzqh approved these changes

@GuangmingLuo GuangmingLuo GuangmingLuo approved these changes

@felix021 felix021 felix021 approved these changes

@YangruiEmma YangruiEmma Awaiting requested review from YangruiEmma

Assignees

@baiyutang baiyutang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

服务注册时使用了tags，但注册后在consul的meta里
5 participants
@baiyutang @felix021 @GuangmingLuo @ppzqh @CoderPoet