Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init registry #2

Merged
merged 27 commits into from
Mar 1, 2022
Merged

Init registry #2

merged 27 commits into from
Mar 1, 2022

Conversation

Hanson
Copy link
Contributor

@Hanson Hanson commented Dec 20, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Hanson
Copy link
Contributor Author

Hanson commented Dec 21, 2021

@longlihale 老哥都好了

YangruiEmma
YangruiEmma reviewed Dec 28, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
example/client/main.go Outdated Show resolved Hide resolved
example/client/main.go Outdated Show resolved Hide resolved
YangruiEmma
YangruiEmma reviewed Dec 28, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@GuangmingLuo
Copy link
Member

All review comments need to be solved before we move on, thanks.

@GuangmingLuo
Copy link
Member

@liu-song please take a look at this pr and leave your review comments if may.

@liu-song
Copy link

hi,@Hanson, 幸苦一下
1 把这个ci 没通过的相关点修复下，ci 也可以在自己fork 的仓库里面开启action就可以测了
2 单元测试的通过需要在CI里面先安装下 consul的服务端，不然无法通过测试
3 把相关函数的功能用英文备注下的功能

@GuangmingLuo GuangmingLuo requested a review from liu-song January 17, 2022 06:06
YangruiEmma
YangruiEmma reviewed Jan 23, 2022
View reviewed changes
consul_registry.go Outdated Show resolved Hide resolved
consul_registry.go Outdated Show resolved Hide resolved
consul_registry.go Outdated Show resolved Hide resolved
consul_registry.go Outdated Show resolved Hide resolved
consul_registry.go Outdated Show resolved Hide resolved
consul_resolver.go Outdated Show resolved Hide resolved
consul_resolver.go Outdated Show resolved Hide resolved
consul_registry.go Outdated Show resolved Hide resolved
consul_registry.go Outdated Show resolved Hide resolved
test/consul_test.go Outdated Show resolved Hide resolved
YangruiEmma
YangruiEmma reviewed Jan 24, 2022
View reviewed changes
test/consul_test.go Outdated Show resolved Hide resolved
@GuangmingLuo
Copy link
Member

hello, checked the latest code and resolved some conversations, more things need to be done:

  1. Please check and fix all the unresolved conversation.
  2. UT need more work in more cases、comments、clean code.
  3. Exported functions need comments.

liu-song
liu-song reviewed Feb 20, 2022
View reviewed changes
example/server/main.go Outdated Show resolved Hide resolved
YangruiEmma
YangruiEmma reviewed Feb 28, 2022
View reviewed changes
consul_registry.go Outdated Show resolved Hide resolved
YangruiEmma
YangruiEmma reviewed Feb 28, 2022
View reviewed changes
consul_test.go Outdated Show resolved Hide resolved
@GuangmingLuo GuangmingLuo merged commit 599a149 into kitex-contrib:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liu-song liu-song liu-song left review comments

@GuangmingLuo GuangmingLuo GuangmingLuo approved these changes

@YangruiEmma YangruiEmma YangruiEmma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Hanson @CLAassistant @GuangmingLuo @liu-song @YangruiEmma @baiyutang