replace prefetchq/eslint-config with eslint v9 config #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kitbag-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stackoverfloweth
commented
Nov 6, 2024
src/types/params.ts
Outdated
| && typeof value.get === 'function' | ||
| && 'set' in value | ||
| && typeof value.set === 'function' | ||
| return typeof value === 'object' && 'get' in value && typeof value.get === 'function' && 'set' in value && typeof value.set === 'function' |
There was a problem hiding this comment.
this too should be resolved
pleek91
reviewed
Nov 6, 2024
pleek91
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the outdated @prefecthq/eslint-config with a local eslint.config built on v9
After merging this, I'll pull back out the dependencies/config into something like @kitbag/eslint-config
I also ran
lint:fixand fixed some manual placeswe can ignore the following errors, I'll explicitly override these rules inside this project when I pull out the config