Update the props store to support prefetching #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kitbag-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pleek91
commented
Oct 10, 2024
| setProps: (route: ResolvedRoute) => void, | ||
| getProps: (id: string, name: string, params: unknown) => MaybePromise<unknown> | undefined, | ||
| setProps: (route: ResolvedRoute, options: { prefetched: boolean }) => void, | ||
| getProps: (id: string, name: string, params: Record<string, unknown>) => unknown, |
There was a problem hiding this comment.
MaybePromise<unknown> | undefined is widened to unknown anyway.
pleek91
commented
Oct 10, 2024
| } | ||
|
|
||
| export function createPropStore(): PropStore { | ||
| const store = reactive(new Map<string, unknown>()) | ||
| const store: Map<string, unknown> = reactive(new Map()) |
There was a problem hiding this comment.
reactive produces a mapped type because of ref unwrapping. Writing this way produces a simpler type for the store.
pleek91
commented
Oct 10, 2024
Comment on lines
+30
to
+32
| if (store.has(key)) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
I'm not 100% sure skipping every time is the right thing to do here. But I think it makes sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP attempt at updating the props store to allow for prefetching. Updates the
setPropsmethod to accept aprefetchboolean and attempts to accurately clear stale props from the store.When
prefetchistrueprops will be put into the store and then we exit. Ifprefetchisfalsethen after putting props into the store we then go delete any props from the store that do not match the route that was passed in.In both cases if a key already exists in the store we do not execute the prop callback for that match. If a key already exists then it was prefetched and shouldn't be fetched again.
@stackoverfloweth hopefully this aligns more with the mental model you had in mind for the props store and prefetching in general.
Note: This doesn't fix the issue with a single boolean not accurately reflecting the fact that a route has multiple matches and each match might have a different prefetch value for props. The
prefetchoption might need to include a callback to determine if the current match should prefetch props based on thePrefetchConfigsfor that match.