Match alphanumeric params only #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+68
to
+70
| type UnifyParamEnds< | ||
| TPath extends string | ||
| > = ReplaceAll<ReplaceAll<TPath, '-', ParamEnd>, '_', ParamEnd> |
There was a problem hiding this comment.
rather than nesting ReplaceAll, could we use a union?
ReplaceAll<TPath, '-' | '_', ParamEnd>There was a problem hiding this comment.
Every time you have a union the type will produce a union. And we want to replace each character individually so the output type is a single template literal.
stackoverfloweth
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loosely conforms the types for route params to match params that end with a
/,-, or_.This is accomplished by replacing
-and_with/on each path prior to parsing out the params. Then/is used same as before. Each character we want to support requires aReplaceAll<path, '-', '/'>type to wrap the path. This is recursive template literal type. So I think there probably is some cost to doing this.For that reason there are some other special characters that I'm not accounting for here that are valid url characters are
.,!,~,*,',(, and). Which are not commonly used. I vote we only add this if necessary but I don't feel strongly.