Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version #10

Merged
merged 4 commits into from
Mar 12, 2024
Merged

update version #10

merged 4 commits into from
Mar 12, 2024

Conversation

stackoverfloweth
Copy link
Collaborator

No description provided.

@stackoverfloweth stackoverfloweth self-assigned this Mar 11, 2024
@pleek91
Copy link
Contributor

pleek91 commented Mar 11, 2024 •
edited
Loading

I think a npm version patch would also update the package-lock.json so might want to double check that.

@stackoverfloweth
Copy link
Collaborator Author

stackoverfloweth commented Mar 12, 2024 •
edited
Loading

I think a npm version patch would also update the package-lock.json so might want to double check that.

@pleek91 great suggestion. I also decided to use this PR to do some other housekeeping in preparation for the first "real release"

  • updated readme
  • moved internal stuff into utilities, not exporting from index
  • added has and clear methods to mapper
  • updated register to accept a single profile in addition to array of profiles
  • wrote a test for that ^

I'm going to have to bump to 0.0.3 though because I already published previous version before this got merged 😅

pleek91
pleek91 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Next up vitepress docs?

@stackoverfloweth stackoverfloweth merged commit 4d58ad6 into main Mar 12, 2024
2 checks passed
@stackoverfloweth stackoverfloweth deleted the 0.0.2 branch March 12, 2024 16:07
@stackoverfloweth
Copy link
Collaborator Author

Nice! Next up vitepress docs?

I was thinking about it lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleek91 pleek91 pleek91 approved these changes

Assignees

@stackoverfloweth stackoverfloweth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stackoverfloweth @pleek91