-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for v2.0.2 #204
Open
ThomasJejkal
wants to merge
8
commits into
main
Choose a base branch
from
development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PR for v2.0.2 #204
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bdb817c
chore(deps): update dependency jacoco to v0.8.12
renovate[bot] 4efdb3c
chore(deps): update dependency gradle to v8.10.2
renovate[bot] 2190607
Merge pull request #202 from kit-data-manager/renovate/jacoco-0.x
ThomasJejkal 9e076de
Merge pull request #203 from kit-data-manager/renovate/gradle-8.x
ThomasJejkal 945e2bb
chore(deps): update dependency gradle to v8.11
renovate[bot] 00df477
Merge pull request #205 from kit-data-manager/renovate/gradle-8.x
ThomasJejkal 1982310
chore(deps): update plugin io.freefair.maven-publish-java to v8.11
renovate[bot] 9433891
Merge pull request #207 from kit-data-manager/renovate/io.freefair.ma…
ThomasJejkal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11-bin.zip | ||
networkTimeout=10000 | ||
validateDistributionUrl=true | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Use of
xargs
andeval
for Argument ParsingThe script now uses
xargs
andeval
to parse and handle JVM options and arguments, which avoids the need for arrays and maintains POSIX compliance.Potential Security Risk with
eval
Using
eval
on variables that include user-supplied content can introduce security vulnerabilities, such as code injection attacks. Even though the variables are expected to contain JVM options, if they are manipulated, it could lead to unintended command execution.Apply this diff to sanitize inputs and avoid security risks:
This modification collects the JVM options safely without using
eval
, reducing the risk of code injection.