Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to support log group tagging #201

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

paulsuh
Copy link
Contributor

@paulsuh paulsuh commented Jun 19, 2024

Add tags to the log group using a parameter when instantiating the CloudWatchLogHandler. Included are:

  • Actual code to do the tagging
  • Unit test for the feature
  • Updated doctoring and documentation in the README file

(Note: I tried to use addCleanup() to delete the log group associated with the test after it is complete, but test runs kept giving a runtime error that the log stream did not exist. This is likely a race condition somewhere working with AWS so I removed the cleanup function.)

@kislyuk kislyuk merged commit ffbc180 into kislyuk:develop Jun 20, 2024
0 of 12 checks passed
@kislyuk
Copy link
Owner

kislyuk commented Jun 20, 2024

Thanks!

@kislyuk
Copy link
Owner

kislyuk commented Aug 21, 2024

Please do not ignore CI failures. I did not look carefully because I assumed that the CI failures were due to AWS credential issues, but this PR had linting and typing errors.

kislyuk added a commit that referenced this pull request Aug 21, 2024
kislyuk added a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants