Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception capture for CreateLogStream to avoid flush get stuck #192

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Add exception capture for CreateLogStream to avoid flush get stuck #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions watchtower/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,13 @@ def _submit_batch(self, batch, log_stream_name, max_retries=5):
# at this point, the first write to the new stream
# should not contain a sequence token at all.
kwargs.pop("sequenceToken", None)
except Exception as e2:
# Make sure exception in CreateLogStream not exit
# this thread but conitnue to retry
warnings.warn(
"Failed to create log stream {} when delivering log: {}".format(log_stream_name, e2),
WatchtowerWarning,
)
finally:
self.creating_log_stream = False
else:
Expand Down