Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: TS errors in KeyboardAvoidingView #733

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

kirillzyusko
Copy link
Owner

📜 Description

Remove contentContainerStyle for KeyboardAvoidingView in documentation as it's not needed and after #711 it trigerrs TS errors.

💡 Motivation and Context

Conditional types were added intentionally to spot issues like this. Glad to see it works 😅

Closes #732

📢 Changelog

Docs

  • remove contentContainerStyle for KeyboardAvoidingView.

🤔 How Has This Been Tested?

Tested on localhost:3000

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added 🐛 bug Something isn't working documentation Improvements or additions to documentation labels Dec 16, 2024
@kirillzyusko kirillzyusko self-assigned this Dec 16, 2024
@kirillzyusko kirillzyusko marked this pull request as ready for review December 16, 2024 15:32
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://kirillzyusko.github.io/react-native-keyboard-controller/pr-preview/pr-733/
on branch gh-pages at 2024-12-16 15:33 UTC

Copy link

argos-ci bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 changed Dec 16, 2024, 3:35 PM

@kirillzyusko kirillzyusko merged commit 095b4da into main Dec 16, 2024
9 checks passed
@kirillzyusko kirillzyusko deleted the docs/kav-example-ts-errors branch December 16, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type errors with KeyboardAvoidingView
1 participant