Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keyboard offset on iOS #727

Closed
wants to merge 43 commits into from
Closed

feat: keyboard offset on iOS #727

wants to merge 43 commits into from

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Dec 12, 2024 •
edited
Loading

To Do

  • port changes to Fabric

📜 Description

💡 Motivation and Context

image

Closes #250

📢 Changelog

JS

iOS

Android

🤔 How Has This Been Tested?

📸 Screenshots (if appropriate):

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko
feat: add basic fs structure for managing keyboard offset (just save …
8f9d196 
…changes before macOS 14 -> macOS 15 update)🤞
@kirillzyusko
feat: more changes to actually move progress further
18585e3
@kirillzyusko
fix: lint, remove iav
18a628f
@kirillzyusko
fix: iOS 16 incorrect height in onEnd event
f5e6270
@kirillzyusko
chore: update TODO
9a7fa35
@kirillzyusko
fix: grow of input breaks onInteractive handler
3d14341
@kirillzyusko
docs: document new API
5f1c5c0
@kirillzyusko
fix: objc lint
68b0900
@kirillzyusko
fix: lint ts
804915e
@kirillzyusko
fix: platform inconsistency, fabric Android build
3138f14
@kirillzyusko
fix: lint ts
3793699
@kirillzyusko
fix: fabric build
f5f605a
@kirillzyusko
fix: suppress detekt violation
8544613
@kirillzyusko
fix: conflicts after rebasing to main
53893e7
@kirillzyusko
fix: iOS unit tests
2a3512c
@kirillzyusko
fix: mock nativeID to pass iOS unit tests
7eff414
@kirillzyusko
fix: swiftformat
026aa71
@kirillzyusko
refactor: create separate class to simplify KeyboardMovementObserver …
c2bca26 
…implementation
@kirillzyusko
refactor: keep progress
e24b0a7
@kirillzyusko
chore: update list of bugs
a9adf8c
@kirillzyusko
fix: no random onStart/onEnd events during interactive keyboard dismi…
d4cd9f6 
…ssal
@kirillzyusko
feat: try to de-attach input accessory view only when keyboard got cl…
fbf5fd3 
…osed (onMove handler still not precise)
@kirillzyusko
fix: SpringAnimation synchronization when keyboard gets hidden
480a62f
@kirillzyusko
fix: synchronize Timing animation
07e6547
@kirillzyusko
chore: update TODO list
d848a12
@kirillzyusko
fix: swiftformat
975ac3b
@kirillzyusko
fix: one swiftlint problem
c10f720
@kirillzyusko
chore: remove TODO (and keep commented code)
cc9b972
@kirillzyusko
fix: swiftformat
7dd2c59
@kirillzyusko
chore: reduce LOC in KeyboardMovementObserver
50cea14
@kirillzyusko kirillzyusko added documentation Improvements or additions to documentation 🍎 iOS iOS specific 👆 interactive keyboard Anything related to interactive keyboard dismissing 🚨 requires API changes 🚨 Changes that requires changes in library API labels Dec 12, 2024
@kirillzyusko kirillzyusko self-assigned this Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://kirillzyusko.github.io/react-native-keyboard-controller/pr-preview/pr-727/
on branch gh-pages at 2024-12-12 12:47 UTC

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

📊 Package size report

Current size Target Size Difference
167914 bytes 164429 bytes 3485 bytes 📈

@argos-ci Argos CI
Copy link

argos-ci bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Dec 12, 2024, 2:30 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kirillzyusko kirillzyusko

Labels
documentation Improvements or additions to documentation 👆 interactive keyboard Anything related to interactive keyboard dismissing 🍎 iOS iOS specific 🚨 requires API changes 🚨 Changes that requires changes in library API
Projects
None yet
Milestone
No milestone
1 participant
@kirillzyusko