You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To achieve a parity with Keyboard API from react-native I decided to add KeyboardController.state() method. By design it should act as Keyboard.metrics() method. The reason why I choose state name instead of metrics is because our data structure returns more like state rather than a metrics - instead of height and layout information we also return additional data, such as duration of last animation, timestamp when last open happened, target of focused input and in future potentially type, appearance and maybe other properties.
📢 Changelog
JS
added KeyboardController.state() method;
Docs
added a reference about KeyboardController.state() method;
🤔 How Has This Been Tested?
Tested manually in example app.
📸 Screenshots (if appropriate):
📝 Checklist
CI successfully passed
I added new mocks and corresponding unit-tests if library API was changed
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kirillzyusko
added
documentation
📜 Description
Added
KeyboardController.state()method.💡 Motivation and Context
To achieve a parity with
KeyboardAPI fromreact-nativeI decided to addKeyboardController.state()method. By design it should act asKeyboard.metrics()method. The reason why I choosestatename instead ofmetricsis because our data structure returns more like state rather than a metrics - instead ofheightand layout information we also return additional data, such asdurationof last animation,timestampwhen last open happened,targetof focused input and in future potentiallytype,appearanceand maybe other properties.📢 Changelog
JS
KeyboardController.state()method;Docs
KeyboardController.state()method;🤔 How Has This Been Tested?
Tested manually in example app.
📸 Screenshots (if appropriate):
📝 Checklist